linux-kernel - Re: [PATCH] Many headers included multiple times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081107130435.884be9f5.akpm@linux-foundation.org>
Date:	Fri, 7 Nov 2008 13:04:35 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steve Kemp <steve.30-11-2008.date@...ve.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Many headers included multiple times

On Sat, 1 Nov 2008 11:15:38 +0000
Steve Kemp <steve.30-11-2008.date@...ve.org.uk> wrote:

>  There are many source files which include the same header multiple
>  times.  Minimal initial patch included here, will submit the rest
>  shortly if there is interest.
> 
>   Quick tool to detect these: http://www.steve.org.uk/Software/kernel/

I flee in terror from patches like this because of the risk that
someone else will delete the _other_ #include, and this patch still
applies OK, so we end up removing both #includes and things break. 
This has happened before.

Thought: if the patch were to delete one #include and to then move the
other one to a different position in the #include order then this
couldn't happen.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/