linux-kernel - Re: [PATCH 4/5] adt7473: Check inputs from sysfs writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4914ACED.8070207@oracle.com>
Date:	Fri, 07 Nov 2008 13:02:37 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Darrick J. Wong" <djwong@...ibm.com>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [PATCH 4/5] adt7473: Check inputs from sysfs writes

Jean Delvare wrote:
> On Fri, 07 Nov 2008 12:49:34 -0800, Joe Perches wrote:
>> On Fri, 2008-11-07 at 11:20 -0800, Andrew Morton wrote:
>>>> +#define ROUND_DIV(x, divisor)	(((x) + ((divisor) / 2)) / (divisor))
>>> It might make sense to rename this to ROUND_CLOSEST, fix the
>>> double-evaluation and whap it into kernel.h?
>> ROUND_HALF_UP?
> 
> What would that supposedly mean?

Just go with DIV_ROUND_CLOSEST() or DIV_ROUND().
The _CLOSEST() is redundant to ROUND .. IMO.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/