linux-kernel - Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081108003209.GB5993@sortiz.org>
Date:	Sat, 8 Nov 2008 01:32:10 +0100
From:	Samuel Ortiz <sameo@...nedhand.com>
To:	David Brownell <david-b@...bell.net>
Cc:	lkml <linux-kernel@...r.kernel.org>, linux-omap@...r.kernel.org
Subject: Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire
	register banks

On Fri, Nov 07, 2008 at 02:00:03PM -0800, David Brownell wrote:
> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> Minor change to the TWL4030 utility interface:  support reads
> of all 256 bytes in each register bank (vs just 255).  This
> can help when debugging, but is otherwise a NOP.
Applied to my for-next branch.
Thanks David.

Cheers,
Samuel.

 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> ---
>  drivers/mfd/twl4030-core.c  |    4 ++--
>  include/linux/i2c/twl4030.h |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
>   *
>   * Returns the result of operation - 0 is success
>   */
> -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
>  {
>  	int ret;
>  	int sid;
> @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
>   *
>   * Returns result of operation - num_bytes is success else failure.
>   */
> -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
>  {
>  	int ret;
>  	u8 val;
> --- a/include/linux/i2c/twl4030.h
> +++ b/include/linux/i2c/twl4030.h
> @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
>   * IMPORTANT:  For twl4030_i2c_write(), allocate num_bytes + 1
>   * for the value, and populate your data starting at offset 1.
>   */
> -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
>  
>  /*----------------------------------------------------------------------*/
>  

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/