[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081112125149.GA13192@ucw.cz>
Date: Wed, 12 Nov 2008 13:51:50 +0100
From: Pavel Machek <pavel@...e.cz>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
mingo@...e.hu, tglx@...utronix.de, torvalds@...ux-foundation.org,
sfr@...b.auug.org.au, linux-next@...r.kernel.org,
srostedt@...hat.com
Subject: Re: [PATCH 1/1] ring-buffer: buffer record on/off switch
On Tue 2008-11-11 12:56:45, Andrew Morton wrote:
> On Tue, 11 Nov 2008 15:06:02 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > +static struct file_operations rb_simple_fops = {
>
> should be const...
>
> Probably it isn't worth fixing. Someone(tm) should do period sweeps -
> 10% of our file_operationses aren't const.
checkptch rule? struct file_operations .* = { -> needs const?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists