lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Nov 2008 14:11:13 +0000 From: Andy Whitcroft <apw@...dowen.org> To: Ingo Molnar <mingo@...e.hu> Cc: Steven Rostedt <rostedt@...dmis.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, tglx@...utronix.de, torvalds@...ux-foundation.org, sfr@...b.auug.org.au, linux-next@...r.kernel.org, srostedt@...hat.com Subject: Re: [PATCH 1/1] ring-buffer: buffer record on/off switch On Tue, Nov 11, 2008 at 10:08:31PM +0100, Ingo Molnar wrote: > > * Steven Rostedt <rostedt@...dmis.org> wrote: > > > > > On Tue, 11 Nov 2008, Andrew Morton wrote: > > > > > On Tue, 11 Nov 2008 15:06:02 -0500 > > > Steven Rostedt <rostedt@...dmis.org> wrote: > > > > > > > +static struct file_operations rb_simple_fops = { > > > > > > should be const... > > > > > > Probably it isn't worth fixing. Someone(tm) should do period sweeps - > > > 10% of our file_operationses aren't const. > > > > Thanks, I never really thought about it. > > > > I'll add to my todo list to send out a patch that cleans all of this > > up. I think I'm guilty at doing this in more than one place. > > Perhaps checkpatch.pl could remind us about it? a new file_operations > struct definition should be const in 99.9% of the cases. Added to my TODO list. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists