linux-kernel - Re: [PATCH] xsysace: use resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081113212121.e7a9f5fe.sfr@canb.auug.org.au>
Date:	Thu, 13 Nov 2008 21:21:21 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Yuri Tikhonov <yur@...raft.com>
Cc:	linux-kernel@...r.kernel.org, Ilya Yanok <yanok@...raft.com>,
	Wolfgang Denk <wd@...x.de>, Detlev Zundel <dzu@...x.de>,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] xsysace: use resource_size_t instead of unsigned long

Hi Yuri,

On Thu, 13 Nov 2008 11:43:17 +0300 Yuri Tikhonov <yur@...raft.com> wrote:
>
> -	dev_dbg(ace->dev, "physaddr=0x%lx irq=%i\n", ace->physaddr, ace->irq);
> +	dev_dbg(ace->dev, "physaddr=0x%llx irq=%i\n", (u64)ace->physaddr, ace->irq);

You should cast the physaddr to "unsigned long long" as "u64" is
"unsigned long" on some architectures.  The same is needed in other
places as well.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped