linux-kernel - Re[2]: [PATCH] xsysace: use resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1124454405.20081114075727@emcraft.com>
Date:	Fri, 14 Nov 2008 07:57:27 +0300
From:	Yuri Tikhonov <yur@...raft.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	linux-kernel@...r.kernel.org, Ilya Yanok <yanok@...raft.com>,
	Wolfgang Denk <wd@...x.de>, Detlev Zundel <dzu@...x.de>,
	<linuxppc-dev@...abs.org>
Subject: Re[2]: [PATCH] xsysace: use resource_size_t instead of unsigned long


Hello Stephen,

On Thursday, November 13, 2008 you wrote:

> Hi Yuri,

> On Thu, 13 Nov 2008 11:43:17 +0300 Yuri Tikhonov <yur@...raft.com> wrote:
>>
>> -     dev_dbg(ace->dev, "physaddr=0x%lx irq=%i\n", ace->physaddr, ace->irq);
>> +     dev_dbg(ace->dev, "physaddr=0x%llx irq=%i\n", (u64)ace->physaddr, ace->irq);

> You should cast the physaddr to "unsigned long long" as "u64" is
> "unsigned long" on some architectures.  The same is needed in other
> places as well.

 Thanks for your comment. We'll fix this.

 Regards, Yuri

 --
 Yuri Tikhonov, Senior Software Engineer
 Emcraft Systems, www.emcraft.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/