linux-kernel - Re: [PATCH] mmc: atmel-mci: move atmel-mci.h file to include/linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <491C3D16.1050501@atmel.com>
Date:	Thu, 13 Nov 2008 15:43:34 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Ben Dooks <ben-linux@...ff.org>, Pierre Ossman <drzeus@...eus.cx>
CC:	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	kernel@...32linux.org
Subject: Re: [PATCH] mmc: atmel-mci: move atmel-mci.h file to include/linux

Ben Dooks :
> On Thu, Nov 13, 2008 at 12:14:13PM +0100, Nicolas Ferre wrote:
>> Needed to use the atmel-mci driver in a architecture
>> independent manner.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
>> ---
>> arch/avr32/boards/atngw100/setup.c       |    2 +-
>> arch/avr32/boards/atstk1000/atstk1002.c  |    2 +-
>> arch/avr32/boards/atstk1000/atstk1003.c  |    2 +-
>> arch/avr32/boards/atstk1000/atstk1004.c  |    2 +-
>> arch/avr32/include/asm/atmel-mci.h       |   39 ------
>> arch/avr32/mach-at32ap/at32ap700x.c      |    2 +-
>> drivers/mmc/host/atmel-mci.c             |    2 +-
>> include/linux/atmel-mci.h                |   39 ++++++
> 
> Would people object to putting this in include/linux/mmc/atmel.h
> to avoid making include/linux abound with device/subsystem/machine
> specific header files?

I tend to agree *but* it seems that header files in include/linux/mmc
are mostly sd/mmc subsystem core files (I mean, not driver ones).
Although, a bunch of atmel-a_driver.h files are already in include/linux...

Pierre, a comment ?

Regards,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/