linux-kernel - Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081113153714.GA1520@ucw.cz>
Date:	Thu, 13 Nov 2008 16:37:14 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Jeremy Katz <katzj@...hat.com>,
	Andres Salomon <dilinger@...ued.net>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jordan Crouse <jordan.crouse@....com>,
	linux-kernel@...r.kernel.org, dsaxena@...top.org
Subject: Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE_LX


> > > > > but what we really need to
> > > > > do is to make geode_gpio* defined even when we're not specifically
> > > > > building with MGEODE_LX.  I'm not sure how best to do that, but the
> > > > > answer probably includes using the generic x86 gpio api.
> > > > 
> > > > This probably needs to be done as a precondition for getting the alsa
> > > > changes merged or the alsa changes need to have the bits which depend on
> > > > geode_gpio ripped out until it can be done.
> > > 
> > > Then let's stop inclusion of asm/geode.h from asm/olpc.h at first.
> > > Any driver codes including asm/geode.h can be broken potentially
> > > without a proper dependency.
> > 
> > Yes, but having a driver dependent on building for a specific x86
> > variant is quite wrong. 
> 
> Not so.  Many drivers are very hardware-specific, and they are (must
> be) based on certain architectures and platforms.  Look at a bunch of
> drivers based on ARM-variants, for example.

No.

It should be possible to compile kernel for i386 and have it run on
OLPC. This breaks it.

CPU type is optimalization option, only.

> IMO, the basic problem is rather that the platform and the CPU
> selection is mixed up.  The geode GPIO stuff shouldn't belong to CPU
> selection.

ACK... and suggested patch makes it worse.

There should be option 'support OLPC' somewhere, and that should
enable the gpio bits. Alsa driver should depend on that one.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/