linux-kernel - Re: [PATCH] drivers/pcmcia/cistpl.c: introduce missing braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081113154538.GB7264@comet.dominikbrodowski.net>
Date:	Thu, 13 Nov 2008 16:45:38 +0100
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Julia Lawall <julia@...u.dk>
Cc:	linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/pcmcia/cistpl.c: introduce missing braces

Hi,

On Thu, Nov 13, 2008 at 11:33:54AM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> The indentation and behavior of the code below suggests that braces are
> intended around the if branch.

good catch, but already fixed in pcmcia-git and on its way to Linux (commit
e689597fe890cf22e23195037aa668c39b25ae4b ) -- many thanks nonetheless!

BTW: is this an automatic test script of some sort? if so, it might be
useful to run this on linux-next kernels, too, so that bugs like this one
are caught before they hit mainline.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/