lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Nov 2008 21:47:25 -0500 (EST) From: Steven Rostedt <rostedt@...dmis.org> To: Andrew Morton <akpm@...ux-foundation.org> cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, Pekka Paalanen <pq@....fi>, Frederic Weisbecker <fweisbec@...il.com>, Steven Rostedt <srostedt@...hat.com> Subject: Re: [PATCH 1/1] ftrace: do not update max buffer with no users On Wed, 12 Nov 2008, Andrew Morton wrote: > > > This sort of thing: > > +#ifdef CONFIG_TRACER_MAX_TRACE > if (current_trace && current_trace->print_max) > iter->tr = &max_tr; > else > +#endif > iter->tr = inode->i_private; > > is particularly regrettable. Another answer is to not allocate it and check for NULL before using it. But this would mean that I would have to find all the places that touch it (the same as the ifdefs) and make sure they are safe. The reason I picked the ifdefs was to guarantee that there were no users if it was not being used. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists