linux-kernel - Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hd4gylrv8.wl%tiwai@suse.de>
Date:	Fri, 14 Nov 2008 07:54:35 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Ingo Molnar <mingo@...e.hu>, Pavel Machek <pavel@...e.cz>,
	Jeremy Katz <katzj@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jordan Crouse <jordan.crouse@....com>,
	linux-kernel@...r.kernel.org, dsaxena@...top.org
Subject: Re: [PATCH] ALSA: cs5535audio: only build OLPC support if	MGEODE_LX is defined

At Thu, 13 Nov 2008 21:38:52 -0500,
Andres Salomon wrote:
> 
> On Fri, 14 Nov 2008 00:30:48 +0100
> Takashi Iwai <tiwai@...e.de> wrote:
> 
> > At Thu, 13 Nov 2008 20:03:39 +0100,
> > Ingo Molnar wrote:
> > > 
> > > 
> > > * Andres Salomon <dilinger@...ued.net> wrote:
> > > 
> > > > On Thu, 13 Nov 2008 17:38:02 +0100
> > > > Pavel Machek <pavel@...e.cz> wrote:
> > > > 
> > > > > On Thu 2008-11-13 11:14:28, Andres Salomon wrote:
> > > > > > On Thu, 13 Nov 2008 16:54:19 +0100
> > > > > > Takashi Iwai <tiwai@...e.de> wrote:
> > > > > > 
> > > > > > > At Thu, 13 Nov 2008 16:37:14 +0100,
> > > > > > > Pavel Machek wrote:
> > > > > > [...]
> > > > > > > > 
> > > > > > > > > IMO, the basic problem is rather that the platform and
> > > > > > > > > the CPU selection is mixed up.  The geode GPIO stuff
> > > > > > > > > shouldn't belong to CPU selection.
> > > > > > > > 
> > > > > > > > ACK... and suggested patch makes it worse.
> > > > > > > > 
> > > > > > > > There should be option 'support OLPC' somewhere, and that
> > > > > > > > should enable the gpio bits. Alsa driver should depend on
> > > > > > > > that one.
> > > > > > > 
> > > > > > > Any better fix patch is welcome, of course :)
> > > > > > > This would make save a lot time than writing mails...
> > > > > 
> > > > > > 
> > > > > > Okay, how about something like the following?
> > > > > 
> > > > > It is wrong. It is valid & useful to compile kernel for i386 and
> > > > > expect all the features on OLPC (with small performance hit).
> > > > 
> > > > No one's debating that.  That requires additional work that will 
> > > > take longer, however.
> > > 
> > > i've zapped this patch meanwhile:
> > > 
> > >  1355c96: x86/olpc: make CONFIG_OLPC dependent on CONFIG_MGEODE_LX
> > > 
> > > because it cripples the ability to run distribution kernels on the 
> > > OLPC.
> > 
> > OK, I reverted also all relevant changes for cs5535audio driver now.
> > The patches are saved in topic/cs5535audio branch, though.
> > 
> > Let's fix OLPC-geode coupling first.
> > 
> 
> 
> Hm, I'd really rather prefer this to be upstream.  The patch I sent adds
> no regressions,

It doesn't build as is, a clear regression :)

> allows the driver to happily coexist with existing
> stuff, and *does* add support if you configure OLPC with MGEODE_LX
> (generic kernels don't get the additional benefits, but those configured
> specifically for OLPC do).

If this dependency issue is solved, of course I'm willing to take it
back.  That's why the patches are still kept in the topic branch.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/