linux-kernel - Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081114075248.GB8397@atrey.karlin.mff.cuni.cz>
Date:	Fri, 14 Nov 2008 08:52:48 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Takashi Iwai <tiwai@...e.de>, Ingo Molnar <mingo@...e.hu>,
	Jeremy Katz <katzj@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jordan Crouse <jordan.crouse@....com>,
	linux-kernel@...r.kernel.org, dsaxena@...top.org
Subject: Re: [PATCH] ALSA: cs5535audio: only build OLPC support if	MGEODE_LX is defined

HI!

> > > i've zapped this patch meanwhile:
> > > 
> > >  1355c96: x86/olpc: make CONFIG_OLPC dependent on CONFIG_MGEODE_LX
> > > 
> > > because it cripples the ability to run distribution kernels on the 
> > > OLPC.
> > 
> > OK, I reverted also all relevant changes for cs5535audio driver now.
> > The patches are saved in topic/cs5535audio branch, though.
> > 
> > Let's fix OLPC-geode coupling first.
> 
> Hm, I'd really rather prefer this to be upstream.  The patch I sent adds
> no regressions, allows the driver to happily coexist with existing
> stuff, and *does* add support if you configure OLPC with MGEODE_LX
> (generic kernels don't get the additional benefits, but those configured
> specifically for OLPC do).

Yes, but the patch is also not a good way of going forward, so it
should not be in mainline.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/