linux-kernel - [PATCH] Fix an uninitialised variable warning in the 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081114162038.23016.20581.stgit@warthog.procyon.org.uk>
Date:	Fri, 14 Nov 2008 16:20:38 +0000
From:	David Howells <dhowells@...hat.com>
To:	linux-serial@...r.kernel.org, akpm@...ux-foundation.org
Cc:	alan@...rguk.ukuu.org.uk, dhowells@...hat.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] Fix an uninitialised variable warning in the 8250 driver

Fix an uninitialised variable warning in the 8250 driver:

  CC      drivers/serial/8250.o
drivers/serial/8250.c: In function 'serial8250_shutdown':
drivers/serial/8250.c:1612: warning: 'i' may be used uninitialized in this function

This has the added advantage of removing a conditional test from the main path
as the BUG_ON() that indicated the loop dropped off the end is now bypassed in
the event of a successful search.  Indeed that BUG_ON() can now be a BUG() as
the only way to reach it automatically makes its condition true.

Signed-off-by: David Howells <dhowells@...hat.com>
---

 drivers/serial/8250.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 303272a..62cf7e5 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -1620,10 +1620,11 @@ static void serial_unlink_irq_chain(struct uart_8250_port *up)
 	hlist_for_each(n, h) {
 		i = hlist_entry(n, struct irq_info, node);
 		if (i->irq == up->port.irq)
-			break;
+			goto found;
 	}
+	BUG();
 
-	BUG_ON(n == NULL);
+found:
 	BUG_ON(i->head == NULL);
 
 	if (list_empty(i->head))

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/