linux-kernel - Re: [PATCH] Fix an uninitialised variable warning in the 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081114163428.7b676742@lxorguk.ukuu.org.uk>
Date:	Fri, 14 Nov 2008 16:34:28 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-serial@...r.kernel.org, akpm@...ux-foundation.org,
	dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix an uninitialised variable warning in the 8250
 driver

On Fri, 14 Nov 2008 16:20:38 +0000
David Howells <dhowells@...hat.com> wrote:

> Fix an uninitialised variable warning in the 8250 driver:
> 
>   CC      drivers/serial/8250.o
> drivers/serial/8250.c: In function 'serial8250_shutdown':
> drivers/serial/8250.c:1612: warning: 'i' may be used uninitialized in this function

Current versions of gcc that I've tested get this all correct just fine
for x86 at least.

Do check that the BUG_ON() helper for whatever platform you are using
needs to correctly indicate that its BUG spewing path may not return
(__attibute((__noreturn__)). I seem to remember some of the architectures
are broken on that.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/