linux-kernel - Re: broken ownership of /proc/sys/ files on 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081116225633.GR28946@ZenIV.linux.org.uk>
Date:	Sun, 16 Nov 2008 22:56:34 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Peter Palfrader <peter@...frader.org>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: broken ownership of /proc/sys/ files on 2.6.27

On Sun, Nov 16, 2008 at 11:44:11PM +0100, Jiri Slaby wrote:
> On 11/16/2008 11:19 PM, Al Viro wrote:
> > --- a/fs/proc/proc_sysctl.c
> > +++ b/fs/proc/proc_sysctl.c
> > @@ -31,6 +31,7 @@ static struct inode *proc_sys_make_inode(struct super_block *sb,
> >  	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
> >  	inode->i_flags |= S_PRIVATE; /* tell selinux to ignore this inode */
> 
> And what about this    ^, is it OK?

Yes, it is.  i_flags is initialized.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/