linux-kernel - Re: Fix broken ownership of /proc/sys/ files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0811161515040.9657@nehalem.linux-foundation.org>
Date:	Sun, 16 Nov 2008 15:23:47 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...IV.linux.org.uk>
cc:	Peter Palfrader <peter@...frader.org>, linux-kernel@...r.kernel.org
Subject: Re: Fix broken ownership of /proc/sys/ files

On Sun, 16 Nov 2008, Al Viro wrote:
>
> D'oh...

So I applied this, but I wonder if it might not be nice to make 
new_inode() (or rather - 'alloc_inode()') initialize some more of the 
really core members.

We already initialize a _lot_ of fields, including fields that most 
filesystem would likely end up re-initializing when reading an inode (like 
i_size and i_nlink). Maybe it would be more sensible to initialize 
i_gid/uid there too, when we are guaranteed to have that cacheline dirty 
anyway (because we're initializing everything around those fields).

But I guess it's not a huge deal. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/