linux-kernel - Re: [PATCH 3/7] memcontrol: use simple_malloc()/simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081116.001637.76266244.davem@davemloft.net>
Date:	Sun, 16 Nov 2008 00:16:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	adobriyan@...il.com
Cc:	laijs@...fujitsu.com, akpm@...ux-foundation.org,
	kamezawa.hiroyu@...fujitsu.com, balbir@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] memcontrol: use simple_malloc()/simple_free()

From: Alexey Dobriyan <adobriyan@...il.com>
Date: Sun, 16 Nov 2008 07:51:28 +0300

> On Sun, Nov 16, 2008 at 12:33:46PM +0800, Lai Jiangshan wrote:
> > use simple_malloc()/simple_free() instead of current codes.
> 
> struct mem_cgroup can't reach the size when kmalloc starts failing.

That's not the point.

When you got past a page, kmalloc/gfp allocations are less reliable,
and people also want NUMA spreading when possible.

That's why we use PAGE_SIZE as the table vmalloc() breakpoint.  We do
this in many places already, with the exact same heuristics, and
for the exact same reasons.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/