linux-kernel - Re: [Xen-devel] [PATCH 03 of 38] swiotlb: allow architectures tooverride swiotlb pool allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49212587.8020702@redhat.com>
Date:	Mon, 17 Nov 2008 09:04:23 +0100
From:	Chris Lalancette <clalance@...hat.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Jan Beulich <jbeulich@...ell.com>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Ingo Molnar <mingo@...e.hu>,
	the arch/x86 maintainers <x86@...nel.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH 03 of 38] swiotlb: allow architectures	tooverride
 swiotlb pool allocation

Jeremy Fitzhardinge wrote:
>> While perhaps less intrusive to take care of, I also didn't see an equivalent
>> of the range_straddles_page_boundary() logic, without which I can't see
>> how this would work in the common case.
>>   
> Could you be more specific?  The swiotlb allocation should be machine 
> contiguous and so there's no stradding required, but I think I'm missing 
> your point.

In general, I think you are right; swiotlb should be machine contiguous, so it
works in the normal case.  The range_straddles_page_boundary function takes care
of a corner case, where you can run into swiotlb exhaustion when you really
shouldn't.  As I understand it, it comes about because it is possible to get a
swiotlb request with two pages that just happen to be machine contiguous, but
were *not* allocated through xen_create_contiguous_region (and hence weren't
marked in the contiguous_bitmap as such).  In this case, you split the request
into two separate requests, and this can more easily lead to exhaustion.
range_straddles_page_boundary works around this by checking whether any two
pages coming through the swiotlb layer are machine contiguous, and if they are,
not splitting the request.

-- 
Chris Lalancette
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/