linux-kernel - Re: [Xen-devel] [PATCH 03 of 38] swiotlb: allow architectures tooverride swiotlb pool allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C546DF64.1F481%keir.fraser@eu.citrix.com>
Date:	Mon, 17 Nov 2008 08:44:20 +0000
From:	Keir Fraser <keir.fraser@...citrix.com>
To:	Chris Lalancette <clalance@...hat.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Xen-devel <xen-devel@...ts.xensource.com>,
	Ian Campbell <ian.campbell@...rix.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [Xen-devel] [PATCH 03 of 38] swiotlb: allow architectures
 tooverride swiotlb pool allocation

On 17/11/08 08:04, "Chris Lalancette" <clalance@...hat.com> wrote:

>> Could you be more specific?  The swiotlb allocation should be machine
>> contiguous and so there's no stradding required, but I think I'm missing
>> your point.
> 
> In general, I think you are right; swiotlb should be machine contiguous, so it
> works in the normal case.  The range_straddles_page_boundary function takes
> care
> of a corner case, where you can run into swiotlb exhaustion when you really
> shouldn't.  As I understand it, it comes about because it is possible to get a
> swiotlb request with two pages that just happen to be machine contiguous, but
> were *not* allocated through xen_create_contiguous_region (and hence weren't
> marked in the contiguous_bitmap as such).  In this case, you split the request
> into two separate requests, and this can more easily lead to exhaustion.
> range_straddles_page_boundary works around this by checking whether any two
> pages coming through the swiotlb layer are machine contiguous, and if they
> are,
> not splitting the request.

A more specific problem solved by range_straddle_page_boundary() in our
2.6.18 kernel was that the block layer would do bio merging because it
checked that pages really were contiguous, and then swiotlb (without
r_s_p_b) would decide that the pages weren't contiguous (because the
contiguity was random luck rather than explicitly requested) and hence do
bounce buffering. Result was that sufficiently aggressive I/O would exhaust
swiotlb resources and crash the kernel.

In the 2.6.18 port we actually got rid of contiguous_bitmap[] entirely.

 -- Keir


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/