linux-kernel - Re: [PATCH] vmscan: fix get_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f11576a0811170932g7f70ab3ai57d03958514124e@mail.gmail.com>
Date:	Tue, 18 Nov 2008 02:32:26 +0900
From:	"KOSAKI Motohiro" <m-kosaki@...es.dti.ne.jp>
To:	"Rik van Riel" <riel@...hat.com>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	"Gene Heskett" <gene.heskett@...il.com>
Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment

2008/11/18 Rik van Riel <riel@...hat.com>:
>
> Fix the old comment on the scan ratio calculations.
>
> Signed-off-by: Rik van Riel <riel@...hat.com>
> ---
>  mm/vmscan.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.28-rc5/mm/vmscan.c
> ===================================================================
> --- linux-2.6.28-rc5.orig/mm/vmscan.c   2008-11-16 17:47:13.000000000 -0500
> +++ linux-2.6.28-rc5/mm/vmscan.c        2008-11-17 12:05:03.000000000 -0500
> @@ -1386,9 +1386,9 @@ static void get_scan_ratio(struct zone *
>        file_prio = 200 - sc->swappiness;
>
>        /*
> -        *                  anon       recent_rotated[0]
> -        * %anon = 100 * ----------- / ----------------- * IO cost
> -        *               anon + file      rotate_sum
> +        *         recent_scanned[anon]
> +        * %anon = -------------------- * sc->swappiness
> +        *         recent_rotated[anon]
>         */
>        ap = (anon_prio + 1) * (zone->recent_scanned[0] + 1);
>        ap /= zone->recent_rotated[0] + 1;

looks good to me, absolutely.
      Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/