linux-kernel - Re: [PATCH] vmscan: fix get_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0811170932390.3468@nehalem.linux-foundation.org>
Date:	Mon, 17 Nov 2008 09:35:25 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rik van Riel <riel@...hat.com>
cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	Gene Heskett <gene.heskett@...il.com>
Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment

Grr. Don't use attachments. Now I can't sanely reply and quote things 
with a sane default setting (yes, I could set "include attachements in 
reply", but that is _not_ a sane default setting, and anybody who claims 
it is is a moron).

Why don't people learn?

Anyway, without quoting, the thing is - your fix isn't any better. The 
more interesting part is how the fractions get combined, and that is 
indeed approximately "anon% = anon / (anon + file)".

So you in many ways made the comment worse. It wasn't good before, but 
it's still not good, and now it comments on the part that isn't even 
interesting (ie it comments the _trivial_ fractional part)

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/