linux-kernel - Re: iwlagn driver segfault in 2.6.28-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081117003941.GA21367@localhost.aei.mpg.de>
Date:	Mon, 17 Nov 2008 01:39:41 +0100
From:	"Carlos R. Mafra" <crmafra2@...il.com>
To:	Tomas Winkler <tomasw@...il.com>
Cc:	reinette chatre <reinette.chatre@...el.com>,
	Lukas Hejtmanek <xhejtman@....muni.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ipw3945-devel@...ts.sourceforge.net" 
	<ipw3945-devel@...ts.sourceforge.net>
Subject: Re: iwlagn driver segfault in 2.6.28-rc3

On Mon 17.Nov'08 at  1:54:16 +0200, Tomas Winkler wrote:
[...]
> Can you please try this one (might be white space broken, just pasted in)

Sure, I've already applied it by hand and will start testing it right away.

But it will take many days until I can report back about it, because
this oops happened only two times in one month or so.

Thanks for taking a look at it, the last time you did my regression
got fixed :-)

> diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c
> b/drivers/net/wireless/iwlwifi/iwl-sta.c
> index 61797f3..d848c63 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-sta.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
> @@ -734,6 +734,12 @@ int iwl_remove_dynamic_key(struct iwl_priv *priv,
>                 return 0;
>         }
> 
> +       if (WARN(priv->stations[sta_id].sta.key.key_offset ==
> WEP_INVALID_OFFSET,
> +               "Removing wrong key %d 0x%x\n", keyconf->keyidx, key_flags)) {
> +               spin_unlock_irqrestore(&priv->sta_lock, flags);
> +               return 0;
> +       }
> +
>         if (!test_and_clear_bit(priv->stations[sta_id].sta.key.key_offset,
>                 &priv->ucode_key_table))
>                 IWL_ERROR("index %d not used in uCode key table.\n",
> 
> Thanks
> Tomas
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/