lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Nov 2008 13:58:40 +0100 (CET) From: Jiri Kosina <jkosina@...e.cz> To: Rafi Rubin <rafi@...s.upenn.edu> cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] n-trig digitizer quirks On Tue, 18 Nov 2008, Rafi Rubin wrote: > +static int ntrig_input_mapping(struct hid_device *hdev, struct hid_input *hi, > + struct hid_field *field, struct hid_usage *usage, > + unsigned long **bit, int *max) > +{ > + if ( (usage->hid & HID_USAGE_PAGE) == HID_UP_DIGITIZER && > + (usage->hid & 0xff) == 0x47) { > + nt_map_key_clear(BTN_TOOL_DOUBLETAP); > + return 1; > + } > + return 0; > +} Could you please keep standard linux-kernel indenting style? I.e. something like static int ntrig_input_mapping(struct hid_device *hdev, struct hid_input *hi, struct hid_field *field, struct hid_usage *usage, unsigned long **bit, int *max) { if ((usage->hid & HID_USAGE_PAGE) == HID_UP_DIGITIZER && (usage->hid & 0xff) == 0x47) { nt_map_key_clear(BTN_TOOL_DOUBLETAP); return 1; } return 0; } > + > +static int ntrig_input_mapped(struct hid_device *hdev, struct hid_input *hi, > + struct hid_field *field, struct hid_usage *usage, > + unsigned long **bit, int *max) > +{ > + unsigned long quirks = (unsigned long)hid_get_drvdata(hdev); This could be removed, as it is never used, right? > +HID_COMPAT_LOAD_DRIVER(ntrig); Also please don't forget to add HID_COMPAT_CALL_DRIVER() entry into hid-dummy.c Besides that it looks OK, so please resend with the above issues fixed, and I'll queue it in my tree. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists