linux-kernel - Re: [PATCH] n-trig digitizer quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492417D4.4090103@seas.upenn.edu>
Date:	Wed, 19 Nov 2008 08:42:44 -0500
From:	Rafi Rubin <rafi@...s.upenn.edu>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] n-trig digitizer quirks

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Could you please keep standard linux-kernel indenting style? I.e. 
> something like

Sorry, just had different settings in my vimrc for something else.

> 
> 
>> +
>> +static int ntrig_input_mapped(struct hid_device *hdev, struct hid_input *hi,
>> +		struct hid_field *field, struct hid_usage *usage,
>> +		unsigned long **bit, int *max)
>> +{
>> +	unsigned long quirks = (unsigned long)hid_get_drvdata(hdev);
> 
> This could be removed, as it is never used, right?

Yes, it wasn't used at the moment, just something left over from using hid-lg.c as a template.  Since this is the only device known for this driver at this point, is it better to keep it shorter and
not check for the duplicate usage from the driver data or would it be better to add the flexibility now?  Also, if you do prefer using driver data like that, is the probe function necessary to make it
work?

Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkkF9IACgkQwuRiAT9o6088RgCfdvu6ntRJ11vh5Ti2CHG+PJJz
SWcAoLrViuX6HO+wEaJnCS+Yt95nAr0D
=qepn
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/