linux-kernel - Re: [PATCH] asm/generic: fix bug - kernel fails to build when enable some common audit code on Blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 19 Nov 2008 08:49:08 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Bryan Wu" <cooloney@...nel.org>, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] asm/generic: fix bug - kernel fails to build when enable some common audit code on Blackfin

On Wed, Nov 19, 2008 at 01:33, Andrew Morton wrote:
> On Tue, 18 Nov 2008 15:03:49 +0800 Bryan Wu wrote:
>> From: Mike Frysinger <vapier.adi@...il.com>
>> If you enable some common audit code, the kernel fails to build.
>>
>> In file included from lib/audit.c:17:
>> include/asm-generic/audit_write.h:3: error: '__NR_swapon' undeclared here (not in a function)
>> make[1]: *** [lib/audit.o] Error 1
>> make: *** [lib] Error 2
>>
>> So do not use __NR_swapon if it isnt defined for a port.
>>
>> Signed-off-by: Mike Frysinger <vapier.adi@...il.com>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>> ---
>>  include/asm-generic/audit_write.h |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/asm-generic/audit_write.h b/include/asm-generic/audit_write.h
>> index f10d367..c5f1c2c 100644
>> --- a/include/asm-generic/audit_write.h
>> +++ b/include/asm-generic/audit_write.h
>> @@ -1,6 +1,8 @@
>>  #include <asm-generic/audit_dir_write.h>
>>  __NR_acct,
>> +#ifdef __NR_swapon
>>  __NR_swapon,
>> +#endif
>>  __NR_quotactl,
>>  __NR_truncate,
>>  #ifdef __NR_truncate64
>
> hrm.
>
> Should blackfin define __NR_swapon instead?  afacit
> include/asm/unistd.h is an exported-to-userspace header, so the
> architecture should export __NR_swapon to prevent userspace build
> failures?

i dont think ports should be forced to define syscalls they dont
support.  no-mmu cant do swap, so Blackfin doesnt define it ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/