linux-kernel - Re: [PATCH] asm/generic: fix bug - kernel fails to build when enable some common audit code on Blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081119070806.GV28946@ZenIV.linux.org.uk>
Date:	Wed, 19 Nov 2008 07:08:06 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Bryan Wu <cooloney@...nel.org>, linux-kernel@...r.kernel.org,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH] asm/generic: fix bug - kernel fails to build when
	enable some common audit code on Blackfin

On Tue, Nov 18, 2008 at 10:33:08PM -0800, Andrew Morton wrote:
> > @@ -1,6 +1,8 @@
> >  #include <asm-generic/audit_dir_write.h>
> >  __NR_acct,
> > +#ifdef __NR_swapon
> >  __NR_swapon,
> > +#endif
> >  __NR_quotactl,
> >  __NR_truncate,
> >  #ifdef __NR_truncate64
> 
> hrm.
> 
> Should blackfin define __NR_swapon instead?  afacit
> include/asm/unistd.h is an exported-to-userspace header, so the
> architecture should export __NR_swapon to prevent userspace build
> failures?

Not in the absense of syscall in question.  Patch applied, will push the
tree tomorrow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/