linux-kernel - Re: [PATCH] IB/ehca: Fix lockdep failures for shca_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1227283347.3599.8.camel@johannes.berg>
Date:	Fri, 21 Nov 2008 17:02:27 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Joachim Fenkes <fenkes@...ibm.com>
Cc:	LinuxPPC-Dev <linuxppc-dev@...abs.org>,
	LKML <linux-kernel@...r.kernel.org>,
	OF-General <general@...ts.openfabrics.org>,
	Roland Dreier <rolandd@...co.com>,
	OF-EWG <ewg@...ts.openfabrics.org>,
	Stefan Roscher <stefan.roscher@...ibm.com>,
	Christoph Raisch <raisch@...ibm.com>,
	Hoang-Nam Nguyen <hnguyen@...ibm.com>
Subject: Re: [PATCH] IB/ehca: Fix lockdep failures for shca_list_lock

On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote:

> +	u64 flags;

> -	spin_lock(&shca_list_lock);
> +	spin_lock_irqsave(&shca_list_lock, flags);

That's wrong and I think will give a warning on all machines where
u64 != unsigned long. Might not particularly matter in this case.

Also, generally it seems wrong to say "fix lockdep failure" when the
patch really fixes a bug that lockdep happened to find.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)