linux-kernel - Re: [PATCH 13/32] rackmeter section fixes

Open Source and information security mailing list archives

Message-Id: <1227390720.7185.276.camel@pasglop>
Date:	Sun, 23 Nov 2008 08:52:00 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	torvalds@...ux-foundation.org, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/32] rackmeter section fixes

On Sat, 2008-11-22 at 17:35 +0000, Al Viro wrote:
> * rackmeter_remove() reference needs devexit_p
> * rackmeter_setup() is calls devinit and is called only from devinit
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

>  drivers/macintosh/rack-meter.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
> --- a/drivers/macintosh/rack-meter.c
> +++ b/drivers/macintosh/rack-meter.c
> @@ -288,7 +288,7 @@ static void __devexit rackmeter_stop_cpu_sniffer(struct rackmeter *rm)
>  	cancel_rearming_delayed_work(&rm->cpu[1].sniffer);
>  }
>  
> -static int rackmeter_setup(struct rackmeter *rm)
> +static int __devinit rackmeter_setup(struct rackmeter *rm)
>  {
>  	pr_debug("rackmeter: setting up i2s..\n");
>  	rackmeter_setup_i2s(rm);
> @@ -582,12 +582,12 @@ static struct of_device_id rackmeter_match[] = {
>  	{ }
>  };
>  
> -static struct macio_driver rackmeter_drv = {
> +static struct macio_driver rackmeter_driver = {
>  	.name = "rackmeter",
>  	.owner = THIS_MODULE,
>  	.match_table = rackmeter_match,
>  	.probe = rackmeter_probe,
> -	.remove = rackmeter_remove,
> +	.remove = __devexit_p(rackmeter_remove),
>  	.shutdown = rackmeter_shutdown,
>  };
>  
> @@ -596,14 +596,14 @@ static int __init rackmeter_init(void)
>  {
>  	pr_debug("rackmeter_init()\n");
>  
> -	return macio_register_driver(&rackmeter_drv);
> +	return macio_register_driver(&rackmeter_driver);
>  }
>  
>  static void __exit rackmeter_exit(void)
>  {
>  	pr_debug("rackmeter_exit()\n");
>  
> -	macio_unregister_driver(&rackmeter_drv);
> +	macio_unregister_driver(&rackmeter_driver);
>  }
>  
>  module_init(rackmeter_init);
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives