linux-kernel - Re: [PATCH 20/32] uninorth-agp section mess

Open Source and information security mailing list archives

Message-Id: <1227390748.7185.277.camel@pasglop>
Date:	Sun, 23 Nov 2008 08:52:28 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	torvalds@...ux-foundation.org, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/32] uninorth-agp section mess

On Sat, 2008-11-22 at 17:36 +0000, Al Viro wrote:
> 'aperture' is declared devinitdata (the whole word of it) and
> is used from ->fetch_size() which can, AFAICS, be used on
> !HOTPLUG after init time.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

> ---
>  drivers/char/agp/uninorth-agp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -27,7 +27,7 @@
>  static int uninorth_rev;
>  static int is_u3;
>  
> -static char __devinitdata *aperture = NULL;
> +static char *aperture = NULL;
>  
>  static int uninorth_fetch_size(void)
>  {
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives