linux-kernel - Re: Is the change to IDE probing really necessary?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081125072156.GA3771@gollum.tnic>
Date:	Tue, 25 Nov 2008 08:21:56 +0100
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	bzolnier@...il.com, sshtylyov@...mvista.com,
	alan@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org
Subject: Re: Is the change to IDE probing really necessary?

[.. ]

> > And the probing _is_ done when loaded as a module so the problem is
> > not with the mask - in your case the probing will work just fine as
> > you need ide0 and ide1, AFAICT.
> 
> Out of curiousity, I loaded ide-generic as a module and tried the suggested
> probe_mask. It loads after e100 which is built in and then has a crap attack
> as it tries to register IO regions which are already registered, triggers
> sysfs warnings for creating duplicate files and then continues along to
> a state where networking doesn't work anyway. That suggestion of 0x3f may
> still catch someone.

Yep, the message could be misleading wrt to the probe_mask. Is something
along the lines of

"please adjust the probe_mask module parameter for probing the rest of the
legacy ISA IDE ports"

more informative? Now it implies that the primary/secondary ports are
probed by default.

However, you still have to set it to something > 0x3 if you want to
probe ide[2-5]. Also, there's still the option of CONFIG_BLK_DEV_GENERIC
which adds support for otherwise unsupported IDE PCI controllers.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/