linux-kernel - Re: [PATCH] use limited register constraint for setnz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2008 08:22:09 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org
Subject: Re: [PATCH] use limited register constraint for setnz


* Steven Rostedt <rostedt@...dmis.org> wrote:

> Impact: fix in compiling
> 
> GCC can decide to use %dil when "r" is used, which is not valid for
> setnz.
> 
> This bug was brought out by Stephen Rothwell's merging of the
> branch tracer into linux-next.
> 
> Signed-off-by: Steven Rostedt <srostedt@...hat.com>
> 
> diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
> index 0be77b3..c2121d2 100644
> --- a/arch/x86/boot/tty.c
> +++ b/arch/x86/boot/tty.c
> @@ -74,7 +74,7 @@ static int kbd_pending(void)
>  {
>  	u8 pending;
>  	asm volatile("int $0x16; setnz %0"
> -		     : "=rm" (pending)
> +		     : "=Qm" (pending)
>  		     : "a" (0x0100));
>  	return pending;
>  }

applied to tip/x86/urgent, thanks Steve!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/