linux-kernel - Re: Detecting endianness in scripts/recordmcount.pl?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081126091752.GA21466@linux-sh.org>
Date:	Wed, 26 Nov 2008 18:17:52 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: Detecting endianness in scripts/recordmcount.pl?

On Wed, Nov 26, 2008 at 05:39:05PM +0900, Paul Mundt wrote:
> Presently there doesn't seem to be any way to determine whether the
> target is big or little endian, and it is assumed that the compiler will
> do the right thing by default. Unfortunately this can not be assumed,
> and mismatches ensue, resulting in the linker bailing out.
> 
> The only obvious solution I saw was to pass in KBUILD_CFLAGS and ld_flags
> along with $(CC) and $(LD) to the script, and killing off the hardcoded
> flags. This at least gets things building, but that still leaves objcopy
> and objdump as the odd ones out. On the other hand, the format can be figured
> out by objdumping the object and reading in the file format line, but people
> obviously do not have consistent naming for these, and a double-pass would
> be needed -- once for establishing little or big, followed by figuring out
> which set of regexes to use.
> 
This is roughly what I had in mind for the objdump test, perhaps
something like this could be reimplemented by someone who knows something
about perl?

---

diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index c67cec8..177f4ee 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -143,6 +143,20 @@ if ($arch eq "x86") {
     }
 }
 
+open(IN, "$objdump -p $inputfile|") || die "error running $objdump";
+
+my $endian = "little";
+
+while (<IN>) {
+	next if /^(\s)*$/;
+	s/^.*file format //g;
+	if (/big/) {
+		$endian = "big";
+	}
+	last;
+}
+close(IN);
+
 if ($arch eq "x86_64") {
     $section_regex = "Disassembly of section\\s+(\\S+):";
     $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:";
@@ -174,10 +188,15 @@ if ($arch eq "x86_64") {
     $type = ".long";
 
     # force flags for this arch
-    $ld .= " -m shlelf_linux";
-    $objcopy .= " -O elf32-sh-linux";
-    $cc .= " -m32";
-
+    if ($endian eq "big") {
+	    $ld .= " -m shelf_linux";
+	    $objcopy .= " -O elf32-shbig-linux";
+	    $cc .= " -mb";
+    } else {
+            $ld .= " -m shlelf_linux";
+            $objcopy .= " -O elf32-sh-linux";
+            $cc .= " -ml";
+    }
 } else {
     die "Arch $arch is not supported with CONFIG_FTRACE_MCOUNT_RECORD";
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/