linux-kernel - Re: [PATCH] tracing/function-return-tracer: set a more human readable output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0811260718570.26424@gandalf.stny.rr.com>
Date:	Wed, 26 Nov 2008 07:21:10 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frédéric Weisbecker <fweisbec@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/function-return-tracer: set a more human readable
 output


On Wed, 26 Nov 2008, Fr?d?ric Weisbecker wrote:

> >>
> >> 3) The first column: single-character visual shortcuts for "overhead".
> >>    This is a concept we used in the -rt tracer and it still lives in
> >>    the latency tracer bits of ftrace and is quite useful:
> >>
> >>     '+' means "overhead spike": overhead is above 10 usecs.
> >>     '!' means "large overhead": overhead is above 100 usecs.
> >>
> >>    These give at-a-glance hotspot analysis - hotspots are easier to
> >>    miss as pure numbers.
> >
> > The latency_trace file has this too. And it uses the above peek to figure
> > it out ;-)
> 
> 
> That's right, the latency_trace does it. But it is based on a
> ring-buffer entry timestamp.
> I wanted to use ring-buffer entry timestamp, but it would be hard to
> calculate the duration
> since the return trace of a function doesn't often follow immediately
> its entry trace.
> And I can't reuse lat_print_timestamp() because I need the nsec
> remaining part....
> 
> This is too specific to reuse latency_trace...

I'd suggest just looking at how those are implemented, and use your own. 
One note, the latency tracer looks at the next entry, even if it is on 
another CPU. This is incorrect, and will definitely be incorrect for you. 
Just use the ring_buffer_iter_peek, that will get you what you want. Well, 
for leaf functions.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/