[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20081126234838.f13ff744.sfr@canb.auug.org.au>
Date: Wed, 26 Nov 2008 23:48:38 +1100
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Andi Kleen <andi@...stfloor.org>
Cc: eranian@...glemail.com, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, mingo@...e.hu, x86@...nel.org,
eranian@...il.com, paulus@...ba.org
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)
Hi Andi,
On Wed, 26 Nov 2008 13:22:17 +0100 Andi Kleen <andi@...stfloor.org> wrote:
>
> On Wed, Nov 26, 2008 at 11:05:29PM +1100, Stephen Rothwell wrote:
> >
> > On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@...stfloor.org> wrote:
> > >
> > > > + * x86 does not need extra alignment requirements for the sampling buffer
> > > > + */
> > > > +#define PFM_ARCH_SMPL_ALIGN_SIZE 0
> > > > +
> > > > +asmlinkage void pmu_interrupt(void);
> > > > +
> > > > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
> > >
> > > All these bitmap wrappers just seem like unnecessary obfuscation.
> > > Could you just drop them and call the standard functions directly?
> >
> > These were added after comments from the PowerPC maintainer since how the
> > bitmaps are accessed needs to be arch specific.
>
> Why? They should not be exported outside, so endian shouldn't matter, should
> it?
See http://lkml.org/lkml/2008/11/9/281 and the followups. Otherwise this
should be answered by Paul and Stephane.
--
Cheers,
Stephen Rothwell sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists