linux-kernel - Re: [patch 05/24] perfmon: X86 generic code (x86)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0811261430120.3325@localhost.localdomain>
Date:	Wed, 26 Nov 2008 14:32:13 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
cc:	Andi Kleen <andi@...stfloor.org>, eranian@...glemail.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, x86@...nel.org, eranian@...il.com
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)

On Wed, 26 Nov 2008, Stephen Rothwell wrote:
> Hi Andi,
> 
> On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@...stfloor.org> wrote:
> >
> > > + * x86 does not need extra alignment requirements for the sampling buffer
> > > + */
> > > +#define PFM_ARCH_SMPL_ALIGN_SIZE	0
> > > +
> > > +asmlinkage void  pmu_interrupt(void);
> > > +
> > > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
> > 
> > All these bitmap wrappers just seem like unnecessary obfuscation.
> > Could you just drop them and call the standard functions directly?
> 
> These were added after comments from the PowerPC maintainer since how the
> bitmaps are accessed needs to be arch specific.

Just because perfmon uses u64 for bitfields instead of unsigned
long, therefor it breaks on BE32 machines.

I have not yet found a good reason why it needs to use u64 instead of
using what's there already.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/