linux-kernel - Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081127150507.GB10188@elte.hu>
Date:	Thu, 27 Nov 2008 16:05:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frédéric Weisbecker <fweisbec@...il.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Tim Bird <tim.bird@...sony.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/function-branch-tracer: enhancements for the
	trace output


* Frédéric Weisbecker <fweisbec@...il.com> wrote:

> I didn't think of ftrace_printk yet. That's a good idea, this way we 
> will see where the ftrace_printk was called, in which function at 
> which depth....
> 
> Don't you think that would be better to have it as C comments. We 
> are in a C-style output and ftrace_printk are especially designed 
> for comments in a trace. That would make sense to read:
> 
>        do_sync_read() {
>           /* sock: 0x12345 flag: 1 */
>           sock_aio_read() {

Nice idea :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/