linux-kernel - Re: [PATCH] arch/frv/kernel/sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9512.1227798352@redhat.com>
Date:	Thu, 27 Nov 2008 15:05:52 +0000
From:	David Howells <dhowells@...hat.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] arch/frv/kernel/sys_frv.c: add missing fput

Julia Lawall <julia@...u.dk> wrote:

> -	if (pgoff & ((1<<(PAGE_SHIFT-12))-1))
> -		return -EINVAL;
> +	if (pgoff & ((1<<(PAGE_SHIFT-12))-1)) {
> +		error = -EINVAL;
> +		goto out_file;
> +	}

There's a better way to fix this.  The check on pgoff should be done before
fget() is called.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/