linux-kernel - Re: [PATCH] memcg reclaim shouldn't change zone->recent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081127035913.GA4168@cmpxchg.org>
Date:	Thu, 27 Nov 2008 04:59:13 +0100
From:	Johannes Weiner <hannes@...xchg.org>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	riel@...hat.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] memcg reclaim shouldn't change zone->recent_rotated statics.

On Thu, Nov 27, 2008 at 12:49:46PM +0900, KAMEZAWA Hiroyuki wrote:
> On Tue, 25 Nov 2008 15:54:22 -0800
> Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Tue, 25 Nov 2008 12:22:53 +0900 (JST)
> > KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
> > 
> > > +	if (scan_global_lru(sc))
> > 
> > mutter.  scan_global_lru() is a terrible function name.  Anyone reading
> > that code would expect that this function, umm, scans the global LRU.
> > 
> > gcc has a nice convention wherein such functions have a name ending in
> > "_p" (for "predicate").  Don't do this :)
> > 
> 
> Hmm, I'll prepare renaming patch.
> 
> scan_global_lru_p() ?

That only works well when you don't have to use underscores, "listp"
or in Lisps where words can be hyphenated "loaded-module-p". 

But scan_global_lru_p() looks terrible.

> or under_scanning_global_lru() ?

How about just scanning_global_lru()?

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/