[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20081127124946.912541e2.kamezawa.hiroyu@jp.fujitsu.com>
Date: Thu, 27 Nov 2008 12:49:46 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, riel@...hat.com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] memcg reclaim shouldn't change zone->recent_rotated
statics.
On Tue, 25 Nov 2008 15:54:22 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Tue, 25 Nov 2008 12:22:53 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
>
> > + if (scan_global_lru(sc))
>
> mutter. scan_global_lru() is a terrible function name. Anyone reading
> that code would expect that this function, umm, scans the global LRU.
>
> gcc has a nice convention wherein such functions have a name ending in
> "_p" (for "predicate"). Don't do this :)
>
Hmm, I'll prepare renaming patch.
scan_global_lru_p() ? or under_scanning_global_lru() ?
Thanks,
-Kame
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists