linux-kernel - Re: [RFC 5/8] param: arch_get_boot_command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081202102330.7c3215a8@hskinnemo-gx745.norway.atmel.com>
Date:	Tue, 2 Dec 2008 10:23:30 +0100
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	linux-kernel@...r.kernel.org, Richard Henderson <rth@...ddle.net>,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Bryan Wu <cooloney@...nel.org>,
	Mikael Starvik <starvik@...s.com>,
	David Howells <dhowells@...hat.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Tony Luck <tony.luck@...el.com>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Ungerer <gerg@...inux.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Grant Grundler <grundler@...isc-linux.org>,
	Paul Mackerras <paulus@...ba.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jeff Dike <jdike@...toit.com>, Ingo Molnar <mingo@...hat.com>,
	Chris Zankel <chris@...kel.net>
Subject: Re: [RFC 5/8] param: arch_get_boot_command_line()

Rusty Russell <rusty@...tcorp.com.au> wrote:
> On Monday 01 December 2008 23:48:07 Russell King wrote:
> > So there's quite a bit which needs to be done to get at the command line.
> > Basically, what's required is:
> >
> > - convert param struct to tag list
> > - if no tag list, use default tag list
> > - run machine specific fixups which may set memory layout
> > - if memory layout has been set, kill off any memory atags to prevent it
> >   being overwritten
> > - parse all atags which includes setting the command line if such a tag
> >   is found
> >
> > Then, and only then can you be sure that you have the right command line.  
> 
>    Thanks for the clue donation.  I've read the code harder now.  Tricky.

I think avr32 might need something similar as it also gets the command
line from a tag list. But we never really do anything tricky with those
tags, so I think it should work to simply move the call to parse_tags()
from setup_arch() into arch_get_boot_command_line().

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/