[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081202174457.GA26005@flint.arm.linux.org.uk>
Date: Tue, 2 Dec 2008 17:44:57 +0000
From: Russell King <rmk+lkml@....linux.org.uk>
To: Rusty Russell <rusty@...tcorp.com.au>
Cc: linux-kernel@...r.kernel.org, Richard Henderson <rth@...ddle.net>,
Haavard Skinnemoen <hskinnemoen@...el.com>,
Bryan Wu <cooloney@...nel.org>,
Mikael Starvik <starvik@...s.com>,
David Howells <dhowells@...hat.com>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Tony Luck <tony.luck@...el.com>,
Hirokazu Takata <takata@...ux-m32r.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Greg Ungerer <gerg@...inux.org>,
Ralf Baechle <ralf@...ux-mips.org>,
Grant Grundler <grundler@...isc-linux.org>,
Paul Mackerras <paulus@...ba.org>,
Heiko Carstens <heiko.carstens@...ibm.com>,
Paul Mundt <lethal@...ux-sh.org>,
"David S. Miller" <davem@...emloft.net>,
Jeff Dike <jdike@...toit.com>, Ingo Molnar <mingo@...hat.com>,
Chris Zankel <chris@...kel.net>
Subject: Re: [RFC 5/8] param: arch_get_boot_command_line()
On Tue, Dec 02, 2008 at 12:43:37PM +1030, Rusty Russell wrote:
> A couple of #if 0 around code I don't think can happen (even in the orignal
> place I moved it from?)
Looking at just those...
> @@ -697,32 +693,48 @@ void __init setup_arch(char **cmdline_p)
> */
> if (tags->hdr.tag != ATAG_CORE)
> convert_to_tag_list(tags);
> +#if 0
> if (tags->hdr.tag != ATAG_CORE)
> tags = (struct tag *)&init_tags;
> +#endif
This prevents 'init_tags' from ever being used, which wil happen if
convert_to_tag_list() doesn't find a param_struct to convert.
> +
> + if (mdesc->fixup)
> + mdesc->fixup(mdesc, tags, &meminfo);
> +
> +#if 0
> + if (tags->hdr.tag == ATAG_CORE) {
> +#endif
This may happen if the memory pointed to by 'tags' gets overwritten for
some reason by a machine specific fixup, but that'll probably never
happen.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists