linux-kernel - Re: [ltt-dev] [PATCH] Poll : introduce poll_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081202134241.1CF4.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Tue,  2 Dec 2008 13:44:51 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Davide Libenzi <davidel@...ilserver.org>
Cc:	kosaki.motohiro@...fujitsu.com,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Ingo Molnar <mingo@...e.hu>, ltt-dev@...ts.casi.polymtl.ca,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	William Lee Irwin III <wli@...omorphy.com>
Subject: Re: [ltt-dev] [PATCH] Poll : introduce poll_wait_exclusive() new function

> > Any thought ?
> 
> That looks fine, but before waving the Thundering Herd flag some 
> performance numbers should be given IMO, considerng also that this is a 
> rather particular use of the poll subsystem.
> Eventually, isn't something like the patch below better than adding custom 
> case names to poll_wait() ALA poll_wait_LONGNAMESFOLLOW()?
> That way you can pass your own queueing function:
> 
> 	poll_wait_qfunc(file, head, pt, add_wait_queue_exclusive);

make sense.
I don't found any bug in your patch.

	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/