linux-kernel - Re: [PATCH -tip] v9 scalable classic RCU implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081203004759.GG6719@linux.vnet.ibm.com>
Date:	Tue, 2 Dec 2008 16:47:59 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, cl@...ux-foundation.org,
	mingo@...e.hu, akpm@...ux-foundation.org, manfred@...orfullife.com,
	dipankar@...ibm.com, josht@...ux.vnet.ibm.com, schamp@....com,
	niv@...ibm.com, dvhltc@...ibm.com, ego@...ibm.com,
	laijs@...fujitsu.com, rostedt@...dmis.org, peterz@...radead.org,
	penberg@...helsinki.fi, tglx@...utronix.de
Subject: Re: [PATCH -tip] v9 scalable classic RCU implementation

On Wed, Dec 03, 2008 at 01:18:12AM +0100, Andi Kleen wrote:
> On Tue, Dec 02, 2008 at 03:51:45PM -0800, Paul E. McKenney wrote:
> > On Wed, Dec 03, 2008 at 12:31:44AM +0100, Andi Kleen wrote:
> > > > o	I now test with a more brutal random-selection online/offline
> > > > 	script (attached).  Probably more brutal than it needs to be
> > > > 	on the people reading it as well, but so it goes.
> > > 
> > > Does that cover both dynticks on and off? afaik the dynticks off problem
> > > I ran into on a 16 thread box and we discussed some time ago is still there.
> > 
> > The failures I see with this patch I also see with mainline.  Are you
> > seeing something with this patch that does not happen with mainline?
> 
> No, that is in mainline too. Sorry to be misleading. Do you see the
> same problems in your testing?

On Power, I see a hang in all three flavors of RCU when CPU hotplug
is enabled and dynticks is not.  I have not yet seen this hang on x86.
On Power, the hang occurs in the CPU-offline code, and is identical to
the hangs I was seeing in 2.6.27, except that "sleep 1" does not hang
in recent 2.6.28 versions.  So the timeout is apparently failing to fire
(or being ignored) for some other reason.

Is this similar to what you are seeing on x86?

I am currently undergoing a line-by-line code walkthrough of rcutree on
the off-chance that all three versions of RCU suffer from the same bug.
(And I have found a few bugs and spelling errors, but nothing related
to the problem at hand.)  If I don't find anything, I will start looking
more closely at the CPU-hotplug code.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/