| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Dec 2008 12:37:22 +0000 From: Alan Jenkins <alan-jenkins@...fmail.co.uk> To: Matthew Garrett <mjg59@...f.ucam.org> CC: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Matt_Domsch@...l.com, greg@...ah.com, linux-acpi@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>, Ivo van Doorn <ivdoorn@...il.com> Subject: Re: [PATCH 2/2 update] misc: Add dell-laptop driver Matthew Garrett wrote: > misc: Add dell-laptop driver > > Add a driver for controling Dell-specific backlight and rfkill interfaces. > This driver makes use of the dcdbas interface to the Dell firmware to allow > the backlight and rfkill interfaces on Dell systems to be driven through the > standardised sysfs interfaces. > > Signed-off-by: Matthew Garrett <mjg@...hat.com> > > --- > > Contains Andrew's suggested updates, plus a fix for a leak on the init > error path. > I see you don't call rfkill_set_default(). Do Dell firmwares support persistent rfkill state? My ill-informed guess is that it shouldn't hurt to call it. If the firmware is sane, it will initialize the rfkill to a useful state. Otherwise, the radio(s) would be unusable without the platform driver. But do feel free to ignore me, if you suspect the firmware of insanity :). Regards Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists