linux-kernel - Re: [PATCH 2/2 update] misc: Add dell-laptop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49368329.19e7300a.0526.5a68@mx.google.com>
Date:	Wed, 03 Dec 2008 13:01:25 +0000
From:	none <alan-jenkins@...fmail.co.uk>
To:	Matthew Garrett <mjg59@...f.ucam.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Matt_Domsch@...l.com, greg@...ah.com,
	linux-acpi@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Ivo van Doorn <ivdoorn@...il.com>
Subject: Re: [PATCH 2/2 update] misc: Add dell-laptop driver

Matthew Garrett wrote:
> misc: Add dell-laptop driver
>     
> Add a driver for controling Dell-specific backlight and rfkill interfaces.
> This driver makes use of the dcdbas interface to the Dell firmware to allow
> the backlight and rfkill interfaces on Dell systems to be driven through the
> standardised sysfs interfaces.
>     
> Signed-off-by: Matthew Garrett <mjg@...hat.com>
>
> ---
>
> Contains Andrew's suggested updates, plus a fix for a leak on the init 
> error path.
>   

Sorry, I should have mentioned this in my first message:

> +	if ((status & (1<<2|1<<8)) == (1<<2|1<<8)) {
> +		wifi_rfkill = rfkill_allocate(NULL, RFKILL_TYPE_WLAN);
> +		if (!wifi_rfkill)
> +			goto err_wifi;
> +		wifi_rfkill->name = "dell-wifi";
> +		wifi_rfkill->toggle_radio = dell_wifi_set;
> +		wifi_rfkill->get_state = dell_wifi_get;
>   

The rfkill doc (and code) say that you also need to initialize
wifi_rfkill->state to the current state of the hardware.

> +		ret = rfkill_register(wifi_rfkill);
> +		if (ret)
> +			goto err_wifi;
> +	}
> +

Regards
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/