linux-kernel - Re: [PATCH] remove isa stuff from smc91x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081203151919.GD5559@pengutronix.de>
Date:	Wed, 3 Dec 2008 16:19:20 +0100
From:	Luotao Fu <l.fu@...gutronix.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Luotao Fu <l.fu@...gutronix.de>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]  remove isa stuff from smc91x driver

On Wed, Dec 03, 2008 at 02:52:35PM +0000, Alan Cox wrote:
> On Wed,  3 Dec 2008 15:48:21 +0100
> Luotao Fu <l.fu@...gutronix.de> wrote:
> 
> > From: Luotao Fu <lfu@...gutronix.de>
> > 
> > ISA support in smc91x is incomplete. I doubt there're any smc91x isa card.
> > This driver is greatly used on arm pxa platforms. Hence we remove the
> > isa stuff from smc91x driver.
> 
> This makes no sense. It is protected by an ifdef anyway so doesn't affect
> ARM

The isa part in smc91x does nothing at all. Get you a unused variable warning if
you turn ISA on and compile it. The io table is defined and not used at all.
Neither does the io address and irq by parameter. I think that these are waste
code and should be removed.

Cheers
Luotao Fu
-- 
   Dipl.-Ing. Luotao Fu | Phone: +49-5121-206917-5004
Pengutronix - Linux Solutions for Science and Industry
Entwicklungszentrum Nord     http://www.pengutronix.de


Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)