linux-kernel - Re: [PATCH] remove isa stuff from smc91x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF69EAE3F6.7E12E2A6-ON80257514.0059AB2C-80257514.005ABFB9@smsc.com>
Date:	Wed, 3 Dec 2008 16:30:23 +0000
From:	Steve.Glendinning@...c.com
To:	Luotao Fu <l.fu@...gutronix.de>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org,
	Luotao Fu <l.fu@...gutronix.de>, netdev@...r.kernel.org,
	Ian.Saturley@...c.com
Subject: Re: [PATCH]  remove isa stuff from smc91x driver

Hi all,

> > > ISA support in smc91x is incomplete. I doubt there're any smc91xisa 
card.
> > > This driver is greatly used on arm pxa platforms. Hence we remove 
the
> > > isa stuff from smc91x driver.
> > 
> > This makes no sense. It is protected by an ifdef anyway so doesn't 
affect
> > ARM
> 
> The isa part in smc91x does nothing at all. Get you a unused 
> variable warning if
> you turn ISA on and compile it. The io table is defined and not used at 
all.
> Neither does the io address and irq by parameter. I think that theseare 
waste
> code and should be removed.

SMSC LAN91C111 *does* still exist on ISA platforms (for example PC104), 
but
Luotao is right: the smc91x driver support for it is broken.

I have one here on an ISA board (and it took me a long time to find 
working PC
hardware old enough to use this!).  I'll send a patch when I can find time 
to
fix it, but until then I agree this broken code should be removed.

Acked-by: Steve Glendinning <steve.glendinning@...c.com>

--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@...c.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/