linux-kernel - Re: [PATCH 2/3] fix warning of not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812051031.08121.rusty@rustcorp.com.au>
Date:	Fri, 5 Dec 2008 10:31:07 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	"Américo Wang" <xiyou.wangcong@...il.com>
Cc:	"Jianjun Kong" <jianjun@...ux.org>,
	"Linux-Kernel-Mailing-List" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/3] fix warning of not used variable

On Thursday 04 December 2008 22:06:33 Américo Wang wrote:
> On Thu, Dec 4, 2008 at 1:00 AM, Jianjun Kong <jianjun@...ux.org> wrote:
> > fix this warning:
> > kernel/module.c:824: warning: 'print_unload_info' defined but not used
> > print_unload_info() just used when CONFIG_PROC_FS was defined.
> >
> > Signed-off-by: Jianjun Kong <jianjun@...ux.org>
>
> Reviewed-by: WANG Cong <wangcong@...ux.org>

My main concern is that this adds two new #ifdef sections.  How about marking 
both cases "inline" instead?

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/