linux-kernel - Re: [PATCH 2/3] fix warning of not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2375c9f90812051652n70475986td3f65a3a364e48dc@mail.gmail.com>
Date:	Sat, 6 Dec 2008 00:52:56 +0000
From:	"Américo Wang" <xiyou.wangcong@...il.com>
To:	"Rusty Russell" <rusty@...tcorp.com.au>
Cc:	"Jianjun Kong" <jianjun@...ux.org>,
	Linux-Kernel-Mailing-List <linux-kernel@...r.kernel.org>,
	"Ingo Molnar" <mingo@...e.hu>
Subject: Re: [PATCH 2/3] fix warning of not used variable

On Fri, Dec 5, 2008 at 12:01 AM, Rusty Russell <rusty@...tcorp.com.au> wrote:
> On Thursday 04 December 2008 22:06:33 Américo Wang wrote:
>> On Thu, Dec 4, 2008 at 1:00 AM, Jianjun Kong <jianjun@...ux.org> wrote:
>> > fix this warning:
>> > kernel/module.c:824: warning: 'print_unload_info' defined but not used
>> > print_unload_info() just used when CONFIG_PROC_FS was defined.
>> >
>> > Signed-off-by: Jianjun Kong <jianjun@...ux.org>
>>
>> Reviewed-by: WANG Cong <wangcong@...ux.org>
>
> My main concern is that this adds two new #ifdef sections.  How about marking
> both cases "inline" instead?
>

Hi, sorry for the delay.

Er, making them inline can solve this problem?